Allow mode
and title
to be omitted in options
argument for createEditor
#3791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3774
Types of changes
Proposed changes
If
options.mode
andoptions.title
are missing, ensure the suffix argument ofRED.editor.generateViewStateId
is something.This permits creating an editor with minimal options.
NOTE: the user should ALWAYS provide an
options
object with the targetelement
. In not doing so, themonaco
editor has no idea where to display the editor. As a level of compatibility to earlier node-red versions (and to prevent an exception), a hidden element will be auto generated in the event ofoptions
oroptions.element
being missing (and a warning will be generated in the browser indicating this) but the UI will not see the editor.Checklist
grunt
to verify the unit tests pass