Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys info (diagnostics report) amendments #3793

Merged
merged 3 commits into from
Jul 21, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #3771

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

  • include flows stop/start state

    • Include flows run / stop state in the report
    • This differs from the existing runtime.isStarted (which is true if the runtime is finished initialising)
  • add a handful of missing settings to basic report

    • Opportunistic chance to add a few missing items that are (functionally) inconsequential but useful for diagnostics
    • I can remove from PR if you prefer these to be in 3.1.0

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested a review from knolleary July 21, 2022 08:33
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.193% when pulling bcd3161 on Steve-Mcl:sys-info-amendments into 1b94cc3 on node-red:master.

@knolleary knolleary merged commit 51d8792 into node-red:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When flows runtime is stopped, diagnostics reports runtime: { isStarted: true }
3 participants