Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update german translation #3802

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Update german translation #3802

merged 2 commits into from
Aug 4, 2022

Conversation

Dennis14e
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

With this PR I update the German translation.
I've often replaced "Berechtigung" with "Anmeldeinformation", since "Berechtigung" stands for "permission" rather than "credential".
Otherwise, it's more minor adjustments or adding texts that have not yet been translated.
Maybe @ralphwetzel can take a look at the PR? :)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Jul 23, 2022

Coverage Status

Coverage remained the same at 68.199% when pulling fe5132b on Dennis14e:patch-de-2 into dc7fef6 on node-red:master.

Copy link
Contributor

@ralphwetzel ralphwetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm reviewing all those proposals changing Berechtigungen to Anmeldeinformationen I feel more and more, that neither of these terms are a good fit for credentials. According to the - at least partially relevant - chapter in the documentation, credentials are "information treated specially", that may be used to grant access to the flows - and as well for other use cases. As there seems to be no clever translation to German (that comes to my mind), I propose to stick to "Credentials" and treat this as a "terminus technicus". As a side effect, interested users will find additional info when net-searching for "credentials" - which is not the case for the other terms.

@Dennis14e
Copy link
Contributor Author

As there seems to be no clever translation to German (that comes to my mind), I propose to stick to "Credentials" and treat this as a "terminus technicus". As a side effect, interested users will find additional info when net-searching for "credentials" - which is not the case for the other terms.

I agree, neither "Berechtigungen" nor "Anmeldeinformationen" is a really good translation of "credentials". Personally, I like the suggestion to simply use the term "Credentials".

Copy link
Contributor

@ralphwetzel ralphwetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Steve-Mcl
Copy link
Contributor

@knolleary is this PR good to go? Has been over checked by @ralphwetzel

@knolleary knolleary merged commit e9eabd6 into node-red:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants