Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide scrollbars until they're needed #3808

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

bonanitech
Copy link
Contributor

@bonanitech bonanitech commented Jul 28, 2022

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

As I mentioned on Slack, most sidebar panels show scrollbars even when they're not needed. This PR changes that by hiding the scrollbars until the content overflows.

Tested on a Mac in Chrome, Safari, and Firefox.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.199% when pulling f454c29 on bonanitech:overflow-auto into dc7fef6 on node-red:master.

@knolleary knolleary merged commit 9734691 into node-red:master Aug 4, 2022
@bonanitech bonanitech deleted the overflow-auto branch August 4, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants