Register subflow module instance node with parent flow #3818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3798
When creating a subflow module instance, we would create the Subflow object then start it before returning back to the parent Flow. However, starting the subflow requires all of its nodes being started - which could involve node lookups (eg
mqtt in
node callingRED.nodes.getNode()
to get ahold of its broker node. For that type of node lookup to work, the flow needs to know the subflow module instance exists - but as that is being done as part of the start code which happens before the parent flow knows about it, the lookups will fail.This PR fixes it by getting the subflow instance registered with the parent Flow before the instance gets started. It isn't the most beautiful fix as the Flow's view of subflow instances should not be externally modifiable like this... but then again, it works.