Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull-down menus of MQTT configuration node #3890

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

In this pull request, I modified pull-down menus in the configuration node of the MQTT node. Currently, the retain fields are not selected as the default. And typedInput menus do not support internationalization.

Screen Shot 2022-09-19 at 0 59 02

By this pull request, I fixed these issues.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.328% when pulling f872e2a on kazuhitoyokoi:master-fixmqttproperty into f060309 on node-red:master.

@knolleary knolleary merged commit 5cda972 into node-red:master Oct 4, 2022
@kazuhitoyokoi
Copy link
Member Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants