Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix change node overwriting msg with itself #3899

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Sep 22, 2022

and add test
to close #3891

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This fixes #3891 where setting change node to move a property to itself results in undefined. It should leave it unchanged
(Bit of an edge case but hey...)

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 68.277% when pulling 3e4c45a on fix-change-self-overwrite into f060309 on master.

@knolleary knolleary merged commit 318f0f1 into master Oct 4, 2022
@Steve-Mcl
Copy link
Contributor

Does this need backport?

@dceejay
Copy link
Member Author

dceejay commented Oct 4, 2022

That would be ideal if there is a fix release planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Change node to move a property to itself deletes the property
4 participants