Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to close #3900 main issue
and add tests
(other fix is commented out but no tests)
Proposed changes
As per #3900 the CSV node omits a string "undefined" if present when going from object to csv - as it assumes it is undefined :-)...
This fix - fixes that - and adds tests.
It also add some extra fixes to actually honour the "include nulls flag" that is currently only used when going from csv to object and not this way round (obj - csv). But these are commented out as they are a change in behaviour so we may not want to release them as-is without nore thought... (and would need changes to tests).
Checklist
grunt
to verify the unit tests pass