Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CSV undefined property #3906

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Sep 30, 2022

to close #3900 main issue
and add tests
(other fix is commented out but no tests)

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

As per #3900 the CSV node omits a string "undefined" if present when going from object to csv - as it assumes it is undefined :-)...
This fix - fixes that - and adds tests.
It also add some extra fixes to actually honour the "include nulls flag" that is currently only used when going from csv to object and not this way round (obj - csv). But these are commented out as they are a change in behaviour so we may not want to release them as-is without nore thought... (and would need changes to tests).

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

to close #3900 main issue
and add tests
(other fix is commented out but no tests)
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 68.328% when pulling e724f21 on Fix-for-csv-undefined-property into f060309 on master.

@knolleary knolleary merged commit 32999ff into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV node omits value of "undefined" from output
3 participants