Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra newline append for multipart file write #3915

Merged
merged 2 commits into from Feb 21, 2023

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Oct 12, 2022

ref Issue #3913

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

If you write a file (previously read in - with msg.parts attached) - in per line mode - with append linefeed set - we currently add an extra line feed due to the blank / null line at the end that closes the file. This fix detects that and stops it happening so you can write out an identical file to that read in more correctly..

This is to address the Issue #3913

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@dceejay
Copy link
Member Author

dceejay commented Oct 14, 2022

Test fail in http-request node for no apparent reason... maybe will pass once latest dev is merged ?

@knolleary
Copy link
Member

Merging is blocked until #3922 is merged and this branch rebased to pickup that fix.

@knolleary knolleary added this to the 3.1 milestone Nov 7, 2022
@knolleary knolleary force-pushed the Fix-file-write-last-line-newline-append branch from 29eb5b0 to 95a7980 Compare November 30, 2022 22:29
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 68.294% when pulling 95a7980 on Fix-file-write-last-line-newline-append into 14e74af on master.

@knolleary knolleary merged commit e612bb6 into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants