Fix extra newline append for multipart file write #3915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref Issue #3913
Proposed changes
If you write a file (previously read in - with msg.parts attached) - in per line mode - with append linefeed set - we currently add an extra line feed due to the blank / null line at the end that closes the file. This fix detects that and stops it happening so you can write out an identical file to that read in more correctly..
This is to address the Issue #3913
Checklist
grunt
to verify the unit tests pass