Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop mode to range node #3935

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Add drop mode to range node #3935

merged 1 commit into from
Nov 30, 2022

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Oct 29, 2022

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

As per a user request https://discourse.nodered.org/t/range-node-requested-action-scale-and-drop-message-outside-input-range/69772 - this PR adds a drop mode to the range node.

If the input msg property is outside of the input range the entire message is dropped... this acts a a simple input filter for out of range messages.

Includes a test.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

and include tests
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 68.198% when pulling 4cc18c2 on Add-drop-mode-to-range-node into 7da3773 on dev.

@knolleary knolleary added this to the 3.1 milestone Nov 7, 2022
@knolleary knolleary merged commit 752fdfe into dev Nov 30, 2022
@knolleary knolleary deleted the Add-drop-mode-to-range-node branch November 30, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants