add global environment variable feature #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
requested changes
Dec 3, 2022
There was a problem hiding this comment.
Generally, this looks great.
I've made some proposed changes - a couple bugs and message updates.
One piece I'd like to look at again is the edit dialog for the global-config node. If a user manages to open it, I think it should help the user know what it contains and how to edit it.
I can create a more solid proposal this week.
packages/node_modules/@node-red/nodes/core/common/91-global-config.html
Outdated
Show resolved
Hide resolved
packages/node_modules/@node-red/editor-client/src/js/ui/env-var.js
Outdated
Show resolved
Hide resolved
packages/node_modules/@node-red/nodes/locales/en-US/common/91-global-config.html
Outdated
Show resolved
Hide resolved
packages/node_modules/@node-red/nodes/locales/en-US/messages.json
Outdated
Show resolved
Hide resolved
packages/node_modules/@node-red/nodes/locales/ja/common/91-global-config.html
Outdated
Show resolved
Hide resolved
…nfig.html Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…r.js Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…global-config.html Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…bal-config.html Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/editor-client/src/js/ui/deploy.js
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/nodes/core/common/91-global-config.html
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Dec 5, 2022
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/nodes/locales/en-US/messages.json
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/editor-client/src/js/ui/env-var.js
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/editor-client/locales/en-US/editor.json
Outdated
Show resolved
Hide resolved
knolleary
reviewed
Dec 5, 2022
packages/node_modules/@node-red/editor-client/locales/ja/editor.json
Outdated
Show resolved
Hide resolved
…r.json Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…itor.json Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…r.js Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
…nfig.html Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
|
@HiroyasuNishiyama happy to get this merged now. Can you resolve the merge conflict on this branch? |
@knolleary Resolved the conflict. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR add global environment variable feature discussed at:
node-red/designs#76
This implementation introduces new special configuration node
global-configand adds Environment tab to User settings menu.Checklist
gruntto verify the unit tests pass