Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support form-data arrays #3991

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Conversation

hardillb
Copy link
Member

@hardillb hardillb commented Dec 24, 2022

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Add the ability to add multiple entries with the same name using an array to a mulitpart form data post as described in this Stack Overflow post:

https://stackoverflow.com/questions/74904546/node-red-send-post-request-and-using-form-data

Currently the array is stringified and added as a single entry in the body.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Dec 24, 2022

Coverage Status

Coverage: 68.263% (+0.006%) from 68.257% when pulling 4c1d7ad on hardillb:http-request-form-array into 113d42e on node-red:master.

@hardillb hardillb marked this pull request as ready for review December 24, 2022 20:36
@knolleary knolleary changed the base branch from master to dev December 27, 2022 13:42
@knolleary knolleary changed the base branch from dev to master December 27, 2022 13:42
@knolleary knolleary merged commit 7870830 into node-red:master Dec 27, 2022
@knolleary
Copy link
Member

It has been noted in #4279 that this causes a change in behaviour that is going to break existing flows.

Give this PR was an attempt to add support for a scenario we don't currently support, I think we can aim to find a way to support it in a more backwards compatible way. As such, I'm going to revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants