Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let themes change radialMenu text colors #3995

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Let themes change radialMenu text colors #3995

merged 1 commit into from
Jan 1, 2023

Conversation

bonanitech
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

As described in node-red-contrib-themes/theme-collection#239, the text in the radial menu becomes unreadable when using themes. This PR fixes that.

Now Then
Default theme SCR-20221229-d6z SCR-20221229-ddr
Dark theme SCR-20221229-dqo SCR-20221229-dqw

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@bonanitech bonanitech mentioned this pull request Dec 29, 2022
Closed
@coveralls
Copy link

Coverage Status

Coverage: 68.261%. Remained the same when pulling f737162 on bonanitech:radialMenu into b3ce0c0 on node-red:master.

@knolleary knolleary merged commit 550eb6e into node-red:master Jan 1, 2023
@bonanitech bonanitech deleted the radialMenu branch April 28, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bonanitech @coveralls @knolleary