Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force IPv4 name resolution to have priority #4019

Merged
merged 1 commit into from Jan 23, 2023

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Jan 23, 2023

to fix Issue #4010
and others (eg) email node server connect fails, and some reported on SO

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This change forces the dns to prioritise ipv4 over ipv6 (node18 has set this other way round - which is causing user issues - eg Issue #4010 - and maybe this https://stackoverflow.com/questions/75200314/node-red-install-fails?noredirect=1#comment132702598_75200314 - and also several recent email node failures to connect to email servers.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

to fix Issue #4010
and others (eg) email node server connect fails, and some reported on SO
@coveralls
Copy link

Coverage Status

Coverage: 68.241% (-0.005%) from 68.246% when pulling d2c9f12 on force-ipv4-lookup-over-ipv6 into 928131c on dev.

@hardillb
Copy link
Member

Reference: nodejs/node#39987

@knolleary knolleary changed the title if possible - force ipv4 name resolution to have priority Force IPv4 name resolution to have priority Jan 23, 2023
@knolleary knolleary merged commit 937c5fe into dev Jan 23, 2023
@dceejay dceejay deleted the force-ipv4-lookup-over-ipv6 branch March 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants