Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validators for complete and link call nodes #4056

Merged
merged 2 commits into from Feb 20, 2023

Conversation

kazuhitoyokoi
Copy link
Member

@kazuhitoyokoi kazuhitoyokoi commented Feb 10, 2023

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Some nodes with validators have guided users to set appropriate settings. For example, an http-in node with an error triangle is easy to understand the lack of the URL path. To guide users in the same style, I added the validators for complete and link call nodes.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage: 68.554%. Remained the same when pulling 81331e6 on kazuhitoyokoi:master-validator into adfc5b3 on node-red:master.

@knolleary knolleary merged commit c9d72d7 into node-red:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants