Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "timers" types to known types #4103

Merged
merged 1 commit into from Mar 20, 2023

Conversation

Steve-Mcl
Copy link
Contributor

fixes #4102

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Ensure serverside function node editor gets a ref to the "timers" types

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage: 68.609%. Remained the same when pulling 97fbad4 on Steve-Mcl:add-missing-timer-types into 586006d on node-red:dev.

@knolleary knolleary merged commit 9f1ac73 into node-red:dev Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timers in Function node show an error (Node-RED: 3.1.0-beta.2 - MONACO 0.36.1)
3 participants