Update dependecies include got #4155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some test failures to investigate - the xml node's main dependency did get an update. But the timeout on the inject node is unexpected (and seen in another PR raised tonight). |
|
The breaking XML test is due to a fix they published for a CVE changing the prototype of the object the module returns. This has broken other users in other ways and an alternative fix for the CVE is being considered. Hopefully they will publish that alternative fix that should get us back on track. |
|
I have merged a workaround to the xml2js issue - we rebuild the output as a proper object. At some point Leonidas-from-XIV/node-xml2js#674 (or a suitable alternative) will get merged and we can revert this hacky workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates some dependencies to pickup fixes.
This includes taking the leap to got 12.x - which is ESM only. This required changing the httprequest node to export an async function - which in turn required a fix to test-helper to support async modules like this (published as 0.3.1).
A few fixes were needed to get the request node tests passing again - largely due to got getting very opinionated and not being afraid to make breaking changes in major version bumps.
This also fixes the insecureHTTPParser option - got really doesn't want you to be able to set that property, so it requires some internal hacking to get it included.
I wasn't planning on a new beta... but I feel like we should do one for this change alone.
Note, this comments out the 'forever' option, that allowed it to reuse http connections. I don't believe this has worked since we moved to got... but got 12 is stricter about passing in unrecognised options. Need to decide on a way forward for that option, as it currently doesn't work.