Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delay node flush issue #4203

Merged
merged 1 commit into from Jun 21, 2023
Merged

Fix delay node flush issue #4203

merged 1 commit into from Jun 21, 2023

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented May 27, 2023

to close #4202

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This fixes Issue #4202 in the delay not not flushing correctly when in rate limit mode.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl linked an issue May 29, 2023 that may be closed by this pull request
Delay node Flush when in rate limit mode leaving empty messages in the queue (3.1.0-beta.3 and 2) #4202
Closed
@knolleary knolleary merged commit 0b3f7db into dev Jun 21, 2023
3 checks passed
@Steve-Mcl Steve-Mcl deleted the fix-delay-node-flush-issue-4202 branch September 12, 2023 06:47
@jberstler jberstler mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delay node Flush when in rate limit mode leaving empty messages in the queue (3.1.0-beta.3 and 2)
2 participants
@dceejay @knolleary