Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection keep-alive in http request node #4228

Merged
merged 1 commit into from Jul 10, 2023

Conversation

knolleary
Copy link
Member

Keep-Alive handling was broken when we moved to got. This fixes it. Need to apply custom http/https agents with the keepAlive flag set (request used to take care of that for you).

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of code looks sane.

Will approve but if you wish I can try out locally - let me know pls.

@knolleary knolleary merged commit 69aacc6 into dev Jul 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http-request-node “Enable connection keep-alive” seems not to work
2 participants