Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for httpStatic middleware #4229

Merged
merged 1 commit into from Jun 21, 2023
Merged

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

This is an alternative proposal to #4125 that appears to have stalled.

Rather than add httpStaticMiddleware as a top level property, this follows the lead of #4109 to support a middleware property on the httpStatic object:

httpStatic: [
    {
            path: '/opt/static/',
            root: '/private/',
            middleware: myCustomHttpMiddleware
    }
]

@knolleary knolleary requested a review from Steve-Mcl June 21, 2023 15:51
@knolleary knolleary mentioned this pull request Jun 21, 2023
6 tasks
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved (looks sane)

Do you want me to pull and test on a windows box Nick?

Happy either way.

Will leave for you do decide / merge.

@knolleary knolleary merged commit 2448e13 into dev Jun 21, 2023
3 checks passed
@knolleary knolleary deleted the 4125-httpstatic-middleware branch June 21, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants