Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSONata in file nodes #4246

Merged
merged 3 commits into from Jul 26, 2023
Merged

Fix JSONata in file nodes #4246

merged 3 commits into from Jul 26, 2023

Conversation

kazuhitoyokoi
Copy link
Member

@kazuhitoyokoi kazuhitoyokoi commented Jul 11, 2023 •
edited

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Generating a file path using the JSONata in the file node doesn't work in the Node-RED 3.1.0-beta.3.
I have tried to fix it in this pull request.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@kazuhitoyokoi kazuhitoyokoi marked this pull request as ready for review July 11, 2023 17:53
Steve-Mcl
Steve-Mcl reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazuhitoyokoi

The changes looks sane, thank you for preparing this PR.

One thing though: could I trouble you to add a test case to prevent regression?

Never mind, I see you added the test case yesterday.

Thank you.

@Steve-Mcl Steve-Mcl self-requested a review July 14, 2023 09:45
@knolleary knolleary mentioned this pull request Jul 26, 2023
Closed
@knolleary knolleary merged commit d21c075 into node-red:dev Jul 26, 2023
3 checks passed
@Steve-Mcl Steve-Mcl linked an issue Jul 26, 2023 that may be closed by this pull request
JSONata not evaluated in write file node in 3.1.0 beta3 node-red/node-red-nodes#1011
Closed
@kazuhitoyokoi
Copy link
Member Author

@Steve-Mcl @knolleary Thank you. I will use the Node-RED v3.1.0-beta.4. :)

@kazuhitoyokoi kazuhitoyokoi deleted the dev-fixfilenode branch August 18, 2023 12:01
@napsi napsi mentioned this pull request Nov 3, 2023
Closed
@knolleary knolleary mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Awaiting requested review from Steve-Mcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONata not evaluated in write file node in 3.1.0 beta3
3 participants
@kazuhitoyokoi @Steve-Mcl @knolleary