Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linefeed codes from "\r\n" to "\n" in Korean message catalogs #4286

Merged
merged 1 commit into from Aug 18, 2023

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

I found that Korean message catalogs use "\r\n" as a linefeed code.

Screenshot 2023-08-18 at 20 48 59

Because "\n" is the default in the Git environment, I think it is a little difficult to check the difference between commits. In this pull request, I have changed the linefeed codes from "\r\n" to "\n".

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 3391d18 into node-red:dev Aug 18, 2023
3 checks passed
@kazuhitoyokoi kazuhitoyokoi deleted the dev-fixlinefeed branch August 19, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants