Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate http -> https for nodered.org #4313

Merged
merged 1 commit into from Sep 5, 2023
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 5, 2023

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Migrate http://nodered.org to secure https://nodered.org since https is the new default.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm satisified the test failure is one of the random timing failures, rather than anything related to this PR.

Given this is useful housekeeping, I'm going to merge now to include in 3.1.

@knolleary knolleary merged commit e18721a into node-red:dev Sep 5, 2023
3 of 4 checks passed
@Rotzbua Rotzbua deleted the fix_https branch February 19, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants