Handle undefined linkType value for existing link-call nodes #4331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on the forum, after upgrading to 3.1.0, an existing
link callnode was showing a validation error. This was because the validation expectedlinkTypeto be set. For old flows, that value could beundefinedwhich ought to have been good enough to implystatic.This modifies the validation so it treats
undefinedasstatic.One side-effect we'll live with is that on editing such a node and clicking 'done' without having made changes, will cause the value to get set to 'static' - and mark the node as dirty. This sometimes causes complaints in the community, but it's a fleeting moment to deal with it.