Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML node: add option for collecting attributes and content #4513

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

gorenje
Copy link
Contributor

@gorenje gorenje commented Jan 5, 2024

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Add a fourth option to the HTML node to collect attributes and html content together. At the moment, it is only possible to either have the attributes or the content of matching elements. This adds an option have both.

Discussed in the forum.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass

all passed but errored out on:

Running "nyc:all" (nyc) task
Fatal error: spawn nyc ENOENT
  • I have added suitable unit tests to cover the new/changed functionality

@gorenje gorenje changed the title HTML node: add option to for attributes and content HTML node: add option for collecting attributes and content Jan 5, 2024
@Steve-Mcl
Copy link
Contributor

Hi @gorenje. thanks for your PR. I think it is a useful addition.

New features should be based of dev (and should target the dev branch)

Would you be kind enough to fix this up please?

Cheers.

@gorenje
Copy link
Contributor Author

gorenje commented Feb 20, 2024

Hi @Steve-Mcl

I'll port over as soon as I get the time. As an alternative, I ended up using cheerio inside a function node ... in case anyone else requires this functionality.

@dceejay dceejay changed the base branch from master to dev March 4, 2024 10:03
@knolleary knolleary merged commit 0b9dd11 into node-red:dev Mar 7, 2024
4 checks passed
@gorenje
Copy link
Contributor Author

gorenje commented Mar 7, 2024

@knolleary thanks for that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants