Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let settings.httpNodeAuth accept single middleware or array of middlewares #4572

Merged
merged 1 commit into from Mar 7, 2024

Conversation

kevinGodell
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This change allows us to use our own authentication middleware in substitution for the built-in basic-auth middleware at the top level of RED.httpNode. The property httpNodeAuth in settings.js can receive a value that is a middleware function or array of middleware functions or fallback to using the built-in basic-auth. This change is backwards compatible. It was discussed on the forum @ https://discourse.nodered.org/t/httpnode-top-level-middleware-to-replace-basic-auth/85654/1

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

…wares to replace built-in basic-auth middleware at top level of RED.httpNode
@knolleary knolleary merged commit d94d137 into node-red:dev Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants