NLS Enablement of Core Node Categories #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -267,9 +267,13 @@ RED.palette = (function() { | |||
| function init() { | |||
| $(".palette-spinner").show(); | |||
| if (RED.settings.paletteCategories) { | |||
| RED.settings.paletteCategories.forEach(createCategoryContainer); | |||
| RED.settings.paletteCategories.forEach(function(category){ | |||
| createCategoryContainer(category, category); // TODO NLS enable categories from settings | |||
There was a problem hiding this comment.
fyi, this can be handled by trying to lookup a message, but fall back to category if it doesn't exist:
RED._("palette.core."+category,{defaultValue:category})
Will add that when I get this merged.
|
I've manually cherry picked the relevant commit from your repository and force-pushed the rebased version of the code. Which basically means, this PR is no longer needed, and you'll need to refresh your fork to the latest code. The quickest way is to delete your fork and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes NLS enablement of core node categories. NLS enablement of user node categories is still in progress.