Update @xmldom/xmldom (#213)

package.json

@@ -57,7 +57,7 @@
     "@types/xml-crypto": "^1.4.2",
     "@types/xml-encryption": "^1.2.1",
     "@types/xml2js": "^0.4.11",
-    "@xmldom/xmldom": "^0.8.3",
+    "@xmldom/xmldom": "^0.8.6",
     "debug": "^4.3.4",
     "xml-crypto": "^3.0.0",
     "xml-encryption": "^3.0.1",

src/xml.ts

@@ -214,6 +214,7 @@ export const parseDomFromString = (xml: string): Promise<Document> => {
         (n) => n.tagName != null && n.childNodes != null
       ).length !== 1
     ) {
+      // This will never happen due to updates in @xmldom/xmldom@0.8.5
       return reject(new Error("Malformed XML; multiple roots detected"));
     }
 

test/test-signatures.spec.ts

@@ -10,10 +10,11 @@ const cert = fs.readFileSync(__dirname + "/static/cert.pem", "ascii");
 
 describe("Signatures", function () {
   const INVALID_SIGNATURE = "Invalid signature";
-  const INVALID_DOCUMENT = "Malformed XML; multiple roots detected";
   const INVALID_DOCUMENT_SIGNATURE = "Invalid document signature";
   const INVALID_ENCRYPTED_SIGNATURE = "Invalid signature from encrypted assertion";
   const INVALID_TOO_MANY_TRANSFORMS = "Invalid signature, too many transforms";
+  const XMLDOM_ERROR =
+    "[xmldom error]\telement parse error: Error: Hierarchy request error: Only one element can be added and only after doctype\n@#[line:57,col:1]";
 
   const createBody = (pathToXml: string) => ({
     SAMLResponse: fs.readFileSync(__dirname + "/static/signatures" + pathToXml, "base64"),
@@ -71,11 +72,7 @@ describe("Signatures", function () {
   describe("Signatures - multiple roots are considered invalid", () => {
     it(
       "multiple roots => invalid",
-      testOneResponse(
-        "/invalid/response.root-signed.multiple-root-elements.xml",
-        INVALID_DOCUMENT,
-        0
-      )
+      testOneResponse("/invalid/response.root-signed.multiple-root-elements.xml", XMLDOM_ERROR, 0)
     );
   });