feat: expose getLogoutResponseUrlAsync publicly (#194)

node-saml · Oct 23, 2022 · cc75f48 · cc75f48
1 parent 27acce1
commit cc75f48
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 1 deletion.
diff --git a/src/saml.ts b/src/saml.ts
@@ -620,7 +620,7 @@ class SAML {
     )(callback);
   }
 
-  protected async getLogoutResponseUrlAsync(
+  async getLogoutResponseUrlAsync(
     samlLogoutRequest: Profile,
     RelayState: string,
     options: AuthenticateOptions & AuthorizeOptions,

diff --git a/test/samlTests.spec.ts b/test/samlTests.spec.ts
@@ -1,4 +1,5 @@
 "use strict";
+import * as sinon from "sinon";
 import { URL } from "url";
 import { expect } from "chai";
 import * as assert from "assert";
@@ -18,6 +19,7 @@ describe("SAML.js", function () {
         logoutUrl: "https://exampleidp.com/path?key=value",
         cert: FAKE_CERT,
         issuer: "onesaml_login",
+        generateUniqueId: () => "uniqueId",
       });
       req = {
         protocol: "https",
@@ -193,5 +195,42 @@ describe("SAML.js", function () {
         });
       });
     });
+
+    describe("getLogoutResponseUrlAsync", function () {
+      let fakeClock: sinon.SinonFakeTimers;
+
+      beforeEach(function () {
+        fakeClock = sinon.useFakeTimers(Date.parse("2020-09-25T16:59:00Z"));
+      });
+
+      afterEach(function () {
+        fakeClock.restore();
+      });
+
+      it("resolves with the same target as getLogoutResponseUrl", function (done) {
+        saml.getLogoutResponseUrl(
+          req.samlLogoutRequest,
+          "",
+          {},
+          true,
+          async function (err, cbTarget) {
+            try {
+              const asyncTarget = await saml.getLogoutResponseUrlAsync(
+                req.samlLogoutRequest,
+                "",
+                {},
+                true
+              );
+              assertRequired(cbTarget);
+              assertRequired(asyncTarget);
+              assert.strictEqual(asyncTarget, cbTarget);
+              done();
+            } catch (err2) {
+              done(err2);
+            }
+          }
+        );
+      });
+    });
   });
 });