Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metadata ContactPerson and Organization #140

Merged
merged 12 commits into from
Aug 15, 2022

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Aug 2, 2022

Description

Hello,
What do you think about this ?

  • Add the possibility to add more fields in the metadata
  • Update package.json to support the type Buffer
  • Add type
  • Add test

Checklist:

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #140 (438724b) into master (718508e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   81.06%   81.10%   +0.04%     
==========================================
  Files          13       13              
  Lines         829      831       +2     
  Branches      242      244       +2     
==========================================
+ Hits          672      674       +2     
  Misses         71       71              
  Partials       86       86              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/metadata.ts 90.47% <100.00%> (+0.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

package.json Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
@cjbarth cjbarth changed the title add metadataExtensions Add support for metadata ContactPerson and Organization Aug 15, 2022
@cjbarth cjbarth merged commit e7767f1 into node-saml:master Aug 15, 2022
@cjbarth cjbarth added the enhancement New feature or request label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants