Skip to content

Include AuthnRequestsSigned attribute in all metadata - #143

Merged
cjbarth merged 6 commits into
node-saml:masterfrom
Its-Just-Nans:add-authnRequestsSigned-options
Aug 16, 2022
Merged

cjbarth merged 6 commits into
node-saml:masterfrom
Its-Just-Nans:add-authnRequestsSigned-options

Conversation

@Its-Just-Nans

Copy link
Copy Markdown
Contributor

Description

Add AuthnRequestsSigned="false" if the options is defined

Checklist:

@codecov

codecov Bot commented Aug 4, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #143 (ef21c5f) into master (cf9d3bc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head ef21c5f differs from pull request most recent head b1eadcb. Consider uploading reports for the commit b1eadcb to get more accurate results

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   80.61%   80.64%   +0.02%     
==========================================
  Files          11       11              
  Lines         810      811       +1     
  Branches      244      245       +1     
==========================================
+ Hits          653      654       +1     
  Misses         71       71              
  Partials       86       86              
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/metadata.ts 90.69% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread README.md Resolved
@Its-Just-Nans
Its-Just-Nans requested a review from cjbarth August 9, 2022 13:23
Comment thread test/tests.spec.ts Resolved
@Its-Just-Nans
Its-Just-Nans requested a review from cjbarth August 16, 2022 10:38
@cjbarth cjbarth added the enhancement Adds a feature, option or export without breaking existing callers label Aug 16, 2022
@cjbarth cjbarth changed the title Add authn requests signed options Include AuthnRequestsSigned attribute in all metadata Aug 16, 2022
@cjbarth
cjbarth merged commit d03d9ae into node-saml:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adds a feature, option or export without breaking existing callers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants