Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all SAML class code to single file #147

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Aug 15, 2022

This reverts #129 and #130 based on discussion #131.

Closes #131.

@cjbarth cjbarth added the chore label Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #147 (d8b95f4) into master (e7767f1) will decrease coverage by 0.48%.
The diff coverage is 72.68%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   81.10%   80.61%   -0.49%     
==========================================
  Files          13       11       -2     
  Lines         831      810      -21     
  Branches      244      244              
==========================================
- Hits          674      653      -21     
  Misses         71       71              
  Partials       86       86              
Impacted Files Coverage Δ
src/saml.ts 78.18% <72.68%> (-4.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor question
1 participant