Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up signature tests #178

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Sep 20, 2022

Description

This cleans up some tests and makes them more correct. It also addresses this comment.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #178 (25df075) into master (187f8ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #178   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          11       11           
  Lines         814      814           
  Branches      246      246           
=======================================
  Hits          657      657           
  Misses         71       71           
  Partials       86       86           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth merged commit 4ca80ae into node-saml:master Sep 21, 2022
@cjbarth cjbarth deleted the simplify-tests branch September 21, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant