Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to remove ADFS references; rename passport-saml #190

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Oct 14, 2022

Description

In preparation for a 4.x release, we want to get the documentation cleaned up. The documentation for this library should be focused on configuration of the library. The IdP-specific directions should be either at passport-saml or in a separate file in this project and shouldn't reference Passport at all.

References #151

@cjbarth cjbarth added the documentation Improvements or additions to documentation label Oct 14, 2022
@cjbarth cjbarth requested a review from markstos October 14, 2022 14:04
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. We don't have the bandwidth to maintain IdP-specific docs. Community-contributed "Discussions" or "Wiki" are better suited for that.

@markstos markstos merged commit b850552 into node-saml:master Oct 19, 2022
@cjbarth cjbarth deleted the doc-update branch October 22, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants