-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] No exported member #475
Comments
I'll take it |
I'm in the same trouble. |
The fix is in master. Can you please update package.json in the dev environment to git+https://github.com/node-saml/passport-saml.git and confirm it works now? @felipefadoni @mrosendin |
@gugu Gugu, it worked here. |
@gugu Thank you very much for the agility in solving the bug. We were here killing ourselves to solve, kkkkkkkk |
Great. @markstos, we need v1.4.1 :) |
It was me who introduced the bug :) |
@gugu is there something we need to do to the GitHub Actions/build to be able to catch a problem like this in the future? |
after we update tests to typescript they will test types as well |
Thanks. Releasing soon. |
Fixed in v1.4.1. |
@gugu The type definition file for multiSamlStrategy.d.ts is empty. so we are using @types/passport-saml. There is some inconsistency in type definition for getAssertion method in Profile between this package and @types/passport-saml.
Please check this error `Argument of type '(req: express.Request, profile: Profile, done: VerifiedCallback) => void' is not assignable to parameter of type 'VerifyWithRequest | VerifyWithoutRequest'. 78 (req: express.Request, profile: Profile, done: VerifiedCallback) => { |
@gugu , can this be closed? @avilashchoudhary6681, @borisbc, @amerblackbird: do you still have this issue even on the 2.x branch? |
"passport-saml": "^1.3.5"
inpackage.json
(which installs 1.4.0)Running
yarn run build
on my system returned this error:Environment
The text was updated successfully, but these errors were encountered: