[BUG] No exported member

[mrosendin]

"passport-saml": "^1.3.5" in package.json (which installs 1.4.0)

Running yarn run build on my system returned this error:

SFO-X74WCJ-M:provisioning-api mrosendin$ yarn run build
yarn run v1.22.4
$ npm-run-all clean tsc copy-assets
$ rm -r dist || true
rm: dist: No such file or directory
$ tsc
src/config/passport.ts:3:10 - error TS2305: Module '"../../node_modules/passport-saml/lib/passport-saml"' has no exported member 'Profile'.

3 import { Profile, Strategy as SamlStrategy, VerifiedCallback } from 'passport-saml';
           ~~~~~~~

src/config/passport.ts:3:45 - error TS2305: Module '"../../node_modules/passport-saml/lib/passport-saml"' has no exported member 'VerifiedCallback'.

3 import { Profile, Strategy as SamlStrategy, VerifiedCallback } from 'passport-saml';
                                              ~~~~~~~~~~~~~~~~

src/config/passport.ts:10:5 - error TS7009: 'new' expression, whose target lacks a construct signature, implicitly has an 'any' type.

 10     new SamlStrategy(
        ~~~~~~~~~~~~~~~~~
 11       {
    ~~~~~~~
...
 28       }
    ~~~~~~~
 29     )
    ~~~~~


Found 3 errors.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "tsc" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Environment

• Node.js version: v14.5.0
• passport-saml version: 1.4.0
• tsc version: 3.3.3333

[gugu]

I'll take it

[felipefadoni]

I'm in the same trouble.

[gugu]

The fix is in master. Can you please update package.json in the dev environment to git+https://github.com/node-saml/passport-saml.git and confirm it works now? @felipefadoni @mrosendin

[felipefadoni]

@gugu Gugu, it worked here.

[felipefadoni]

@gugu Thank you very much for the agility in solving the bug. We were here killing ourselves to solve, kkkkkkkk

[gugu]

Great. @markstos, we need v1.4.1 :)

[gugu]

@gugu Thank you very much for the agility in solving the bug. We were here killing ourselves to solve, kkkkkkkk

It was me who introduced the bug :)

[cjbarth]

@gugu is there something we need to do to the GitHub Actions/build to be able to catch a problem like this in the future?

[gugu]

after we update tests to typescript they will test types as well

[markstos]

Thanks. Releasing soon.

[markstos]

Fixed in v1.4.1.

[avilashchoudhary6681]

@gugu The type definition file for multiSamlStrategy.d.ts is empty. so we are using @types/passport-saml. There is some inconsistency in type definition for getAssertion method in Profile between this package and @types/passport-saml.

getAssertion(): object
getAssertion(): Record<string, unknown>
passport-saml: 1.4.2

Please check this error

`Argument of type '(req: express.Request, profile: Profile, done: VerifiedCallback) => void' is not assignable to parameter of type 'VerifyWithRequest | VerifyWithoutRequest'.
Type '(req: express.Request, profile: Profile, done: VerifiedCallback) => void' is not assignable to type 'VerifyWithRequest'.
Types of parameters 'profile' and 'profile' are incompatible.
Type 'import("/Projects/node-commons/node_modules/@types/passport-saml/index").Profile' is not assignable to type 'import("/Projects/node-commons/node_modules/passport-saml/lib/passport-saml/types").Profile'.
Type 'Profile' is not assignable to type '{ issuer?: string | undefined; sessionIndex?: string | undefined; nameID?: string | undefined; nameIDFormat?: string | undefined; nameQualifier?: string | undefined; spNameQualifier?: string | undefined; ... 5 more ...; getSamlResponseXml(): string; }'.
The types returned by 'getAssertion()' are incompatible between these types.
Type 'object' is not assignable to type 'Record<string, unknown>'.
Index signature is missing in type '{}'.

78 (req: express.Request, profile: Profile, done: VerifiedCallback) => {
`

[cjbarth]

@gugu , can this be closed?

@avilashchoudhary6681, @borisbc, @amerblackbird: do you still have this issue even on the 2.x branch?