compatibility with @types/passport-saml, fixes #475 #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
reviewed
Oct 29, 2020
|
inmemory cache provider is included with the module, express types added, thanks @cjbarth |
|
Just to be thorough, can we try downloading all this code to an empty folder and just trying to build it and run tests and see if will will work in such a "clean" environment? Otherwise from my phone I can't see anything else. |
|
|
cjbarth
approved these changes
Oct 29, 2020
|
@cjbarth can I merge? |
|
Thanks for handling this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before I did not include typings in package.json, but typescript still detects new definitions and turns off @types/passport-saml package
This PR adds compatibility with @types/passport-saml