skip KeyDescriptor if decryptionPvk is not provided #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks for the PR! |
ploer
added a commit
that referenced
this pull request
Aug 4, 2015
skip KeyDescriptor if decryptionPvk is not provided
|
Will batch up a couple of changes this week to push. |
ploer
pushed a commit
that referenced
this pull request
Aug 4, 2015
…or in if needed, rather than deleting it if unneeded.
|
/me glances at your picture and does double take. I think I know that guy. :-) |
|
haha, hi PL! |
achingbrain
pushed a commit
to achingbrain/passport-saml
that referenced
this pull request
Aug 5, 2015
…yDescriptor in if needed, rather than deleting it if unneeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SAML:2.0:metadata:
if KeyDescriptor exists, then it must have a KeyInfo element.
The change is to delete[A] the
metadataKeyDescriptor property ifdecryptionPvkis not supplied.[A]: From oozcitak/xmlbuilder-js@9540ea4, null values will be preserved.