generateServiceProviderMetadata: remove callbackUrl dependency #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, can I get you to resolve the conflicts I just created, and maybe add a test case under generateServiceProviderMetadata that constructs the callback url from protocol/path/host? Thanks! |
gnawhleinad
force-pushed
the
remove_callback_url
branch
2 times, most recently
from
46f4298
to
d578141
Compare
gnawhleinad
force-pushed
the
remove_callback_url
branch
from
14be558
to
321d6bd
Compare
|
Done! |
ploer
added a commit
that referenced
this pull request
Aug 6, 2015
generateServiceProviderMetadata: remove callbackUrl dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mirrors
generateAuthorizeRequest's behavior of constructingcallbackUrlfromprotocolandpathifcallbackUrlis not supplied.I kept
reqindependent fromgenerateServiceProviderMetaDataby adding ahostoption that defaults tolocalhost.