Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NameID value mapping #246

Closed
wants to merge 6 commits into from
Closed

Conversation

vpalmisano
Copy link

Fixes #245

@markstos
Copy link
Contributor

markstos commented Nov 1, 2017

Thanks for the contribution.

The patch needs automated test coverage to be accepted. You could break out attrValueMapper into it's own function and then unit test that.

@huntdm07
Copy link

I've just added a similar PR that might fix this.

@markstos
Copy link
Contributor

For reference, the PR @huntdm07 is referring to is: #249

@vpalmisano
Copy link
Author

Hi all,
with the latest changes, I added the possibility to define a custom attrValueMapper function. With no option set, the default function is used.

@cjbarth
Copy link
Collaborator

cjbarth commented Dec 15, 2020

Since #427 and #245 are closed, should this be closed too @vpalmisano ?

@cjbarth
Copy link
Collaborator

cjbarth commented Mar 19, 2021

This appears to be closed by other PRs. No response from author. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attrValueMapper fails to parse complex AttributeValue tags
4 participants