Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple authnContext #298

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Sep 11, 2018

This addresses issue #181 and supersedes PR #183. Please see those other two entries for context.

@markstos
Copy link
Contributor

Looks good. Thanks. Merging.

QA Log

  • I confirmed that SAML 2 support multiple authentication contexts. ref

@cjbarth
Copy link
Collaborator Author

cjbarth commented Sep 11, 2018

As soon as this is released I'll update the TypeScript typings for this. Is there any interest in maintaining the typings for this project here?

@markstos markstos merged commit 45af79e into node-saml:master Sep 11, 2018
@markstos
Copy link
Contributor

@cjbarth Only if you maintain them. My team plans to adopt the TypeScript in the future, but hasn't currently. The project is changing at a slow rate now, so maintenance to the TypeScript bindings should be infrequent.

@cjbarth
Copy link
Collaborator Author

cjbarth commented Sep 11, 2018

In that case, I'll leave them over at DefinitelyTyped for now.

@cjbarth cjbarth deleted the multiple-authn-context branch September 11, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants