New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entryPoint is compulsory for signed requests #299

Merged

markstos merged 1 commit into node-saml:master from cjbarth:entry-point-check

Sep 25, 2018

Collaborator

cjbarth commented Sep 12, 2018

This supersedes PR #269 and relates to issue #267. Please see those items for a discussion of this PR.


          entryPoint is compulsory for signed requests

9178d80

Contributor

markstos commented Sep 25, 2018

@cjbarth Thanks for updating the docs and tests as well as the code. As discussed in #267, this changes fixes a spec compliance issue.

The diff looked good to me. Merging.

markstos merged commit f7aab5c into node-saml:master

This was referenced Sep 25, 2018

Issue #267 #269

Closed

Bypass Vulnerability if entryPoint misconfigured #267

Closed

cjbarth deleted the entry-point-check branch

September 25, 2018 14:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment