Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds signing key in the metadata service provider generation. #306

Merged
merged 1 commit into from Oct 3, 2018

Conversation

tmoiron
Copy link

@tmoiron tmoiron commented Oct 2, 2018

Continue previous PR 275
#275

Made errors while rebasing the previous PR.

So I made another branch with only one commit issued from base master branch.

Hope everything is OK.

@markstos markstos added needs-review Ready for a collaborator to review. breaking-change Not backwards compatible. Requires major version bump. 1.0 labels Oct 2, 2018
@markstos
Copy link
Contributor

markstos commented Oct 2, 2018

Thanks! In the future, another option is to "force push" on the original branch replace the commits on it. I'll get this reviewed.

@cjbarth
Copy link
Collaborator

cjbarth commented Oct 2, 2018

For my own edification, where is the part of the spec that this refers to. I haven't been having any issues with the way things have been working so far, so I want to dig into this a little more.

@tmoiron
Copy link
Author

tmoiron commented Oct 3, 2018

For my own edification, where is the part of the spec that this refers to. I haven't been having any issues with the way things have been working so far, so I want to dig into this a little more.

You may have a look at Metadata for the OASIS Security Assertion Markup Language (SAML) V2.0 page 15 paragraph 2.4.1.1.

You can also browse xsd metadata schema with xsd browser website
md:EntityDescriptor > md:SPSSODescriptor > md:KeyDescriptor > ds:KeyInfo

Hope this will convince you on this modification usefulness

@markstos markstos merged commit 4b02e16 into node-saml:master Oct 3, 2018
@cjbarth cjbarth removed the needs-review Ready for a collaborator to review. label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Not backwards compatible. Requires major version bump.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants