Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logout): handle null and undefined on nameQualifier #311

Merged
merged 1 commit into from Oct 11, 2018

Conversation

sibelius
Copy link
Contributor

@sibelius sibelius commented Oct 5, 2018

microsoft outlook returns

nameQualifier
spNameQualifier

as null instead of undefined

so this PR address this to handle both null and undefined

@markstos
Copy link
Contributor

I manually tested the logic before and after several values: undefined, null, '', 'string', and 0.

I found that the only change in the logic was to treat both "undefined" and "null" the same way, as intended, I'm merging this.

Some automated tests here could be helpful to prevent a related regression in the future.

@markstos markstos merged commit a4998ea into node-saml:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants