add support for encrypted nameIDs in SLO request handling #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could you amend to mention the support for the feature in the docs as well? https://github.com/bergie/passport-saml#slo-single-logout I've merged some other stuff today and hope to put out a new release within the week. |
eero3
force-pushed
the
support-for-encrypted-NameIDs-in-SLO-request-handling
branch
from
f5e9ec2
to
fffe972
Compare
|
I added a bullet point about the feature into the README file as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to handle encrypted nameID on IdP-Initiated SLO.
PR is literally updated version of stale #345 with added test.
Test xml was generated with onelogin saml tools.
All credits to @siren.
Fixes #196