Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade xml-encryption to 1.0.0 #420

Merged
merged 2 commits into from Feb 11, 2020
Merged

Upgrade xml-encryption to 1.0.0 #420

merged 2 commits into from Feb 11, 2020

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Feb 6, 2020

This is an old work account. Please reference @brandonchinn178 for all future communication


Currently running into this: auth0/node-xml-encryption#55

@markstos
Copy link
Contributor

This patch is not complete because it does not updated yarn.lock.

@markstos markstos merged commit 707211c into node-saml:master Feb 11, 2020
@markstos
Copy link
Contributor

This should have perhaps been treated as a breaking change as upgrading to xml-encryption disables insecure algorithm. (Or it's a bug fix, depending how you look at it!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants