Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Singleline private keys #423

Merged
merged 3 commits into from Feb 19, 2020
Merged

Singleline private keys #423

merged 3 commits into from Feb 19, 2020

Conversation

big-kahuna-burger
Copy link
Contributor

markstos
markstos requested changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This OK, but need some documentation added back. We can document that single-line keys will be treated as if they contained the "-----BEGIN PRIVATE KEY----- / -----END PRIVATE KEY-----" header and footer. I assume it i could make a different if the key was wrapped with "BEGIN RSA PRIVATE KEY" or some other header / footer combo and I think we should be clear exactly the format we support.

Thanks for including some test coverage with it!

@markstos markstos merged commit fb1bda0 into node-saml:master Feb 19, 2020
@markstos
Copy link
Contributor

Released in 1.3 .3 today.

@big-kahuna-burger big-kahuna-burger deleted the key2pem branch February 19, 2020 16:10
@jonathansamines jonathansamines mentioned this pull request Jan 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstos markstos markstos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@big-kahuna-burger @markstos