Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 8 #462

Merged
merged 1 commit into from Oct 28, 2020
Merged

Conversation

walokra
Copy link
Contributor

@walokra walokra commented Oct 12, 2020

Node 8 LTS has been EOL since 2019-12-31. Current LTS is Node >=10, see: https://github.com/nodejs/Release.

Also the library doesn't build on Node 8: "error chalk@4.1.0: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.10.0""

Node 8 LTS has been EOL since 2019-12-31. Current LTS is Node >=10, see: https://github.com/nodejs/Release.
@markstos markstos merged commit 08482ad into node-saml:master Oct 28, 2020
@cjbarth cjbarth added dependencies Pull requests that update a dependency file breaking-change Not backwards compatible. Requires major version bump. labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Not backwards compatible. Requires major version bump. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants