Add GitHub Actions as Continuos Integration provider #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run lint and tests on Node.js 10 and 12
cjbarth
requested changes
Oct 12, 2020
.github/workflows/workflow.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [10.x, 12.x] |
There was a problem hiding this comment.
Node 14 is released, but hasn't entered LTS, I think we should test against that too.
There was a problem hiding this comment.
Node 14 LTS starts 2020-10-27 so maybe it's reasonable to already enable testing againts it although the documentation states that "We only support Long-Term Support versions of Node.".
There was a problem hiding this comment.
I feel like, while we only support LTS versions, if a version is Current and will become LTS, we should probably add it to tests so that we aren't surprised by something.
cjbarth
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI had been removed when project was renamed to node-saml and thus tests are not run anymore to verify package state. This PR replaces Travis CI with GitHub Actions as it does the job and keeps everything in one place.
The CI task runs lint and tests on Node.js 10 and 12. Build Status is shown in a badge.