Only make an attribute an object if it has child elements #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like the correct solution to resolve the regression, however, I am interested in hearing comments from others about the bigger change for the next semver major release. |
cjbarth
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
undefinedattrValueMapperbehaviour so that it returns the value of_(which will be the char value string orundefined) unless the SAML AttributeValue has child elements, in which case it returns the AttributeValue as an object.Branch https://github.com/node-saml/passport-saml/tree/csh-issue-459-attr-value-regression-ec presents an alternative approach which would have wider impact/implications.
Closes #459