Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecation notice for privateCert; fix bug #492

Merged
merged 1 commit into from Nov 3, 2020
Merged

Add deprecation notice for privateCert; fix bug #492

merged 1 commit into from Nov 3, 2020

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Nov 3, 2020

This adds the deprecation notice for privateCert in favor of privateKey. It also fixes a bug introduced in the refactoring of privateCert to privateKey.

markstos
markstos approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@markstos markstos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is cleaner.

@markstos markstos merged commit c2f32c6 into node-saml:master Nov 3, 2020
@cjbarth cjbarth deleted the privateCert-deprecation branch November 3, 2020 19:49
@cjbarth cjbarth added the bug label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstos markstos markstos approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjbarth @markstos